Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified observability] Migrate deprecated IndexPattern types #124286

Closed
wants to merge 11 commits into from

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 1, 2022

Summary

Closes #122318

Migrate the deprecated IndexPattern types to DataView. It also renames some of our own methods that used the deprecated terminology.

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Unified observability labels Feb 1, 2022
@afgomez afgomez marked this pull request as ready for review February 7, 2022 12:46
@afgomez afgomez requested a review from a team as a code owner February 7, 2022 12:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@afgomez afgomez requested a review from a team February 7, 2022 12:46
@afgomez afgomez force-pushed the 122318-index-pattern-deprecated branch from 2e63cc9 to 68656d0 Compare February 7, 2022 12:50
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 392.2KB 391.9KB -280.0B
uptime 735.8KB 735.8KB -16.0B
total -296.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 85.0KB 85.0KB -20.0B
Unknown metric groups

References to deprecated APIs

id before after diff
observability 132 2 -130

History

  • 💚 Build #21341 succeeded 2e63cc992d3609ebd1917e9207b0ed5162bea201
  • 💚 Build #21165 succeeded 94387b86265431bc3f3bfae7dc2b24a8818dbc3e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez
Copy link
Contributor Author

afgomez commented Feb 8, 2022

Due to #124169 this solution is already deprecated. I'll start clean in a different PR and close this one

@afgomez afgomez closed this Feb 8, 2022
@afgomez afgomez deleted the 122318-index-pattern-deprecated branch February 8, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unified Observability] Replace deprecated IndexPattern types
3 participants